Repository navigation
Enable numactl for will-it-scale testcases - #568
Merged
Merged
Conversation
Few testcases especially memory based testcases shows too much run-2-run variance when ran for say 10 iterations. But when run with the command prefix "$numactl --membind=0" the variance goes away. This patch adds numactl parameter which can be set to true(default: false) in the job.yaml based on user's requirements. Signed-off-by: Suneeth D <Suneeth.D@amd.com>
|
thanks for the patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few testcases especially memory based testcases shows too much run-2-run variance when ran for say 10 iterations. But when ran with the command prefix "$numactl --membind=0" the variance went away.
This patch adds numactl parameter which can be set to true(default: false) in the job.yaml based on user's requirements.
BEFORE THIS PATCH:
~# cat /lkp/result/will-it-scale/thread-0-tlb_flush2/ubuntu/defconfig/gcc-13/7.0.1-3cb1fb7a56d2-fc720ae009/*/stats.json | grep ops
"will-it-scale.per_thread_ops": 191581,
"will-it-scale.per_thread_ops": 194834, --------
| ---> std.dev = 52%
"will-it-scale.per_thread_ops": 93022, --------
"will-it-scale.per_thread_ops": 193322,
"will-it-scale.per_thread_ops": 92636,
"will-it-scale.per_thread_ops": 192691,
"will-it-scale.per_thread_ops": 92523,
"will-it-scale.per_thread_ops": 194624,
"will-it-scale.per_thread_ops": 92631,
"will-it-scale.per_thread_ops": 191742,
AFTER THIS PATCH:
~# cat /lkp/result/will-it-scale/thread-0-tlb_flush2/ubuntu/defconfig/gcc-13/7.0.1-with-numactl/*/stats.json | grep ops
"will-it-scale.per_thread_ops": 94992,
"will-it-scale.per_thread_ops": 92187,
"will-it-scale.per_thread_ops": 93766,
"will-it-scale.per_thread_ops": 92625,
"will-it-scale.per_thread_ops": 91759,
"will-it-scale.per_thread_ops": 93097,
"will-it-scale.per_thread_ops": 92295,
"will-it-scale.per_thread_ops": 91981,
"will-it-scale.per_thread_ops": 93588,
"will-it-scale.per_thread_ops": 92053,