Skip to content

[SYCL] Add missing noexcept to sycl::id functions - #22898

Merged
KornevNikita merged 4 commits into
intel:syclfrom
emdevv:emdevv/22869
Aug 20, 2026
Merged

[SYCL] Add missing noexcept to sycl::id functions#22898
KornevNikita merged 4 commits into
intel:syclfrom
emdevv:emdevv/22869

Conversation

@emdevv

@emdevv emdevv commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #22869 !

This pr adding noexcept to all functions, including operators.

@emdevv
emdevv marked this pull request as ready for review August 7, 2026 07:53
@emdevv
emdevv requested a review from a team as a code owner August 7, 2026 07:53
@emdevv
emdevv requested a review from againull August 7, 2026 07:53
@emdevv emdevv changed the title Adding noexcept to all functions, including operators [SYCL] Adding noexcept to all functions, including operators Aug 7, 2026
@KornevNikita KornevNikita changed the title [SYCL] Adding noexcept to all functions, including operators [SYCL] Add missing noexcept to sycl::id functions Aug 10, 2026
KornevNikita
KornevNikita approved these changes Aug 10, 2026
View reviewed changes

@KornevNikita KornevNikita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @emdevv please fix the format

@KornevNikita

KornevNikita commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@againull could you take a look please

@emdevv
emdevv force-pushed the emdevv/22869 branch 3 times, most recently from 055ee12 to bc146c8 Compare August 11, 2026 21:06
@emdevv

emdevv commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Hi @KornevNikita . Sorry for the delay, I have fixed the formatting with git clang-format HEAD~, and I hope it's alright now.

@KornevNikita

KornevNikita commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Hi @KornevNikita . Sorry for the delay, I have fixed the formatting with git clang-format HEAD~, and I hope it's alright now.

format issues are still here - please check the output of the job

@emdevv

emdevv commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

Hi @KornevNikita . Sorry for delay, I'm not able to solve the issues with clang format, I tried also on two setups ( windows & fedora ) . I see that this pr #22889 also have the same issues. Is there any chance that I can get some help to get the clang format changes pushed on my branch ? Thanks .

@emdevv

emdevv commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Hello @KornevNikita . The failing job was unable to download the necessary artifacts, can I get a rerun? Also are there any other things that need to be done for this pr to be merged besides passing CI?

@KornevNikita
KornevNikita merged commit ea9645d into intel:sycl Aug 20, 2026
29 of 30 checks passed
@KornevNikita

KornevNikita commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@emdevv thanks for working on this!

@KornevNikita KornevNikita mentioned this pull request Aug 20, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cperkinsintel cperkinsintel cperkinsintel approved these changes
@KornevNikita KornevNikita KornevNikita approved these changes
@againull againull Awaiting requested review from againull againull is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Align the id class with SYCL 2020

3 participants

@emdevv @KornevNikita @cperkinsintel