Skip to content

Add lock_configuration, unlock_configuration and load_configuration - #153

Open
krihal wants to merge 1 commit into
internap:masterfrom
krihal:new_capabilities
Open

krihal wants to merge 1 commit into
internap:masterfrom
krihal:new_capabilities

Conversation

@krihal

@krihal krihal commented Sep 2, 2019

Copy link
Copy Markdown

Three new capabilities.

@fbouliane

Copy link
Copy Markdown
Contributor

Hi Kihal,
Thanks for the pull-request !

As we are trying to have achieve as much coverage in unit test as possible, do you have sample on how a real switch reacts when you issue those commands (xml rpc payload). I guess you can take a look at the netconf_protocol_test.py to understand how we test things. We could add those payloads to explain how the switch reacts to those commands.

Also, after a quick look I'm not sure adding those methods resulted in any feature. Does this change the initial capability message ?

Thanks again

@fbouliane fbouliane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need more details as unit test or explanation of usage of the feature.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants