Skip to content

fix(knowledge): stop witnessing Cargo.toml, which every release rewrites #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbrown merged 1 commit into from
Oct 23, 2026
Merged

fix(knowledge): stop witnessing Cargo.toml, which every release rewrites #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions docs/knowledge/repository-knowledge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@
},
{
"kind": "decision",
"source": "Cargo.toml",
"subject": "http://aegis.gastown.local/ontology/code/tambo/Cargo.toml",
"summary": "The package and primary command are tambo, while the Rust library import name remains caboodle and a legacy caboodle binary is explicitly declared for compatibility.",
"source_sha256": "d1fbb60bb8460f96413ef15235be4b98e54dbd513793c66e339e99f286641bbc",
"source": "docs/book/src/compatibility.md",
"subject": "http://aegis.gastown.local/ontology/doc/tambo/docs%2Fbook%2Fsrc%2Fcompatibility.md",
"summary": "The product and primary command are tambo; the caboodle command, Rust crate imports, state paths and published vocabulary IRIs remain valid compatibility contracts.",
"source_sha256": "8a88bd07116fdac607c21fd3533b8f1c150d203f881805de002e09a855a7c2b9",
"type": "DecisionRecord",
"properties": {
"status": "active",
Expand Down Expand Up @@ -90,10 +90,10 @@
},
{
"kind": "start-here",
"source": "Cargo.toml",
"subject": "http://aegis.gastown.local/ontology/code/tambo/Cargo.toml",
"summary": "Read the declared library and binary names before integrating the crate or changing compatibility assumptions.",
"source_sha256": "d1fbb60bb8460f96413ef15235be4b98e54dbd513793c66e339e99f286641bbc",
"source": "docs/book/src/compatibility.md",
"subject": "http://aegis.gastown.local/ontology/doc/tambo/docs%2Fbook%2Fsrc%2Fcompatibility.md",
"summary": "Read the compatibility contracts before integrating the crate or changing naming assumptions: the caboodle alias, crate imports and stored identities are retained.",
"source_sha256": "8a88bd07116fdac607c21fd3533b8f1c150d203f881805de002e09a855a7c2b9",
"properties": {
"startHereOrder": 3
}
Expand Down
9 changes: 9 additions & 0 deletions scripts/test-repository-knowledge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,15 @@ def test_source_bound_nonempty_content(self):
self.assertNotIn("/content>", text)
self.assertNotIn("owl#sameAs", text)

def test_release_managed_files_are_never_witnesses(self):
# release-please rewrites these on every release PR and tag, so a witness on
# one fails every release's pendant controls and its tagged share build.
managed = {"Cargo.toml", "Cargo.lock", "CHANGELOG.md", ".release-please-manifest.json"}
self.assertEqual(managed & {r["source"] for r in self.registry["records"]}, set())
for name in managed:
(self.root / name).write_text("version bumped by the release PR\n")
self.render()

def test_absent_or_ambiguous_index_pointer_refuses(self):
for value in (None, False, ""):
with self.subTest(value=value), self.assertRaisesRegex(ValueError, "absent or ambiguous"):
Expand Down
Loading