Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes output filename handling when switching between presets with different suffixes.
A derived output filename could previously be interpreted as an explicitly selected filename after loading another preset. As a result, the output filename was no longer recomputed with the newly loaded suffix, and suffixes could accumulate, for example:
document_EM.pdf->document_EM_DL.pdfinstead of:
document_EM.pdf->document_DL.pdfThe change keeps automatically derived output names in derived mode when a preset is loaded, while preserving explicitly selected output filenames.
It also clears persisted output-file state when starting a new application session, so the first opened document does not inherit a stale output filename from the previous session.
Verification
_EMapplies_EM._DLreplaces_EMwith_DLinstead of accumulating suffixes.mvn -pl distribution -am -DskipTests clean package: BUILD SUCCESS.mvn clean install: 5 DSS test failures. The same 5 failures reproduce unchanged on a clean, unmodifiedupstream/mastercheckout at commit6c9623d.Documentation
No documentation change is needed.
website/docs/JSignPdf.adocalready describes the intended behavior: the output suffix is stored in presets and is used to derive the output filename unless an explicit output file is selected.