Conversation
The Proxy Port field in TSA/Validation settings only wrote the typed value back to the view model via setOnAction(), which JavaFX only fires on Enter in that field. Typing a port and then clicking elsewhere (Save, another field, another tab) leaves the on-screen text unpersisted, so buildProxyConfig() (DssSigningEngine) silently uses whatever was last committed - Constants.DEFVAL_PROXY_PORT (80) if nothing ever was - while the proxy host (bound bidirectionally) updates correctly. This produces a confusing failure: DSS connects to the configured proxy host on port 80 instead of the port shown in the settings dialog. txtProxyHost already uses a proper bindBidirectional(); the port needs manual String<->int handling, but was missing the focus-loss commit that the same pattern already uses elsewhere in this codebase (see commitFontSize() / txtFontSize in SignatureSettingsController), which commits on both Enter and focus-loss and reverts to the last valid value on parse failure. This mirrors that same pattern for consistency.
Member
|
Merged, thanks! Good catch. Two paths the focus-loss listener can't reach, so I followed up in #513: menu accelerators ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Proxy Port field in TSA/Validation settings only wrote the typed value back to the view model via setOnAction(), which JavaFX only fires on Enter in that field. Typing a port and then clicking elsewhere (Save, another field, another tab) leaves the on-screen text unpersisted, so buildProxyConfig() (DssSigningEngine) silently uses whatever was last committed - Constants.DEFVAL_PROXY_PORT (80) if nothing ever was - while the proxy host (bound bidirectionally) updates correctly. This produces a confusing failure: DSS connects to the configured proxy host on port 80 instead of the port shown in the settings dialog.
txtProxyHost already uses a proper bindBidirectional(); the port needs manual String<->int handling, but was missing the focus-loss commit that the same pattern already uses elsewhere in this codebase (see commitFontSize() / txtFontSize in SignatureSettingsController), which commits on both Enter and focus-loss and reverts to the last valid value on parse failure. This mirrors that same pattern for consistency.