Repository navigation
fix: harden multi-sig concurrency and submission safety - #3
Merged
Merged
Conversation
Mystery-CLI
pushed a commit
that referenced
this pull request
Sep 25, 2026
…cations fix: secure multisig authorization and signer workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens multi-signature transaction collection and submission across the four requested issues:
MultiSigSignaturerecords with a unique(txId, signerPublicKey)constraint and composite XDR rebuilding so concurrent signer updates cannot erase one another.pending -> submittingcompare-and-swap claim so only one concurrent submission can reach Horizon; failed submissions return topendingfor retry.Validation
prisma validate --schema backend/prisma/schema.prismapassed.git diff --checkpassed.backend/tests/multiSig.test.jssuite was run; it contains legacy hand-rolled Stellar/Prisma mock incompatibilities and unrelated baseline failures under this fork. The repository pre-commit PII scan also reports 14 pre-existing email-like fixtures outside the changed files.Closes Ethereal-Future#1279
Closes Ethereal-Future#1280
Closes Ethereal-Future#1281
Closes Ethereal-Future#1282