This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Feature: Store pruned transaction hashes in a cuckoo filter#1417
Open
kwek20 wants to merge 13 commits into
Open
Feature: Store pruned transaction hashes in a cuckoo filter#1417kwek20 wants to merge 13 commits into
kwek20 wants to merge 13 commits into
Conversation
6 tasks
Contributor
|
Need to properly prioritize the merging of this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to track pruned confirmed transaction hashes to a cuckoo filter before we delete them.
At the end of each pruning cycle we want to persist the cuckoo filter state in the db.
We will currently maintain 10 cuckoo filters maximum, once a new filter gets added (another pruning cycle)
the first gets deleted.
Each filter is maintained in the database by an index, and when restored from database, the lowest index will be first to get deleted.
Fixes # (issue)
#1370
Type of change
How Has This Been Tested?
Checklist: