This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Ability to toggle cache on/off#1706
Open
acha-bill wants to merge 2 commits into
Open
Conversation
|
|
||
| Cache<Indexable, TransactionViewModel> cache = tangle.getCache(TransactionViewModel.class); | ||
| if (cache != null) { | ||
| if (cache.get(hash) == null) { |
Contributor
There was a problem hiding this comment.
| import com.iota.iri.model.persistables.ObsoleteTag; | ||
| import com.iota.iri.model.persistables.Tag; | ||
| import com.iota.iri.model.persistables.Transaction; | ||
| import com.iota.iri.model.persistables.*; |
Contributor
There was a problem hiding this comment.
| import java.util.HashMap; | ||
| import java.util.HashSet; | ||
|
|
||
| import org.junit.*; |
Contributor
There was a problem hiding this comment.
Comment on lines
+100
to
+102
| if (cache == null) { | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
So store doesn't do anything?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because we want to run JMH tests in cache on/off states, we need to check if cache is
nullfor when it's off.Type of change
How Has This Been Tested?
Checklist: