This repository was archived by the owner on Aug 23, 2020. It is now read-only.
reset getInclusion reg test assertion to what it should be#1819
Merged
GalRogozinski merged 3 commits intoApr 3, 2020
Merged
Conversation
Contributor
|
I see buildkite fails with this... By the way are you getting mail notifications when buildkite fails? |
Contributor
Author
DyrellC
approved these changes
Apr 2, 2020
DyrellC
left a comment
DyrellC
left a comment
Contributor
There was a problem hiding this comment.
Let's get this merged. Tests are passing again.
kwek20
approved these changes
Apr 2, 2020
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
Value Transactions are confirmed, 10 txs are issued on a node and all are referenced by a milestone. All the txs are supposed to be confirmed. Yet, the last was not. This was happening on buildkite.I thought there was a race condition on buildkite. So I fixed the test instead. This was an effort to allow other tests to pass.
This PR resets it to what it should have been in the first place.
Type of change
Checklist: