Skip to content

Enable optional CI code signing #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamdriscoll merged 1 commit into from
Jul 22, 2026
Merged

Enable optional CI code signing #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,24 @@ on:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
workflow_dispatch:
inputs:
sign_code:
description: Sign build outputs
required: false
type: boolean
default: false

jobs:
build:
name: Build repository
timeout-minutes: 120
runs-on: windows-latest
env:
SIGNING_CODE: ${{ github.event_name == 'workflow_dispatch' && inputs.sign_code && secrets.SIGNING_CODE || '' }}
AZURE_CLIENT_ID: ${{ github.event_name == 'workflow_dispatch' && inputs.sign_code && secrets.AZURE_CLIENT_ID || '' }}
AZURE_TENANT_ID: ${{ github.event_name == 'workflow_dispatch' && inputs.sign_code && secrets.AZURE_TENANT_ID || '' }}
AZURE_CLIENT_SECRET: ${{ github.event_name == 'workflow_dispatch' && inputs.sign_code && secrets.AZURE_CLIENT_SECRET || '' }}

steps:
- name: Checkout
Expand Down Expand Up @@ -77,21 +89,13 @@ jobs:
shell: pwsh
run: |
.\PowerShellToolsPro.Cmdlets\build.ps1
env:
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}

- name: Build VS Code extension
shell: pwsh
run: |
Import-Module .\Build\Modules\InvokeBuild\5.14.23\InvokeBuild.psd1 -Force
Install-Module Microsoft.PowerShell.PlatyPS -RequiredVersion 1.0.1 -Scope CurrentUser -Force -AllowClobber
Invoke-Build -File .\vscode\vscode.build.ps1
env:
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}

- name: Upload Visual Studio extensions
uses: actions/upload-artifact@v4
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ jobs:
run: |
.\PowerShellToolsPro.Cmdlets\build.ps1
env:
SIGNING_CODE: ${{ secrets.SIGNING_CODE }}
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
Expand All @@ -87,6 +88,7 @@ jobs:
Install-Module Microsoft.PowerShell.PlatyPS -RequiredVersion 1.0.1 -Scope CurrentUser -Force -AllowClobber
Invoke-Build -File .\vscode\vscode.build.ps1
env:
SIGNING_CODE: ${{ secrets.SIGNING_CODE }}
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
Expand Down
9 changes: 7 additions & 2 deletions Build/sign.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
param($Path)

$signingCode = $env:SIGNING_CODE
if ([string]::IsNullOrWhiteSpace($signingCode) -or $signingCode -eq 'false' -or $signingCode -eq '0') {
Write-Warning "Code signing is disabled. Skipping signing."
return
}

$OpenAuthenticode = Import-Module OpenAuthenticode -PassThru -ErrorAction Ignore
if ($null -eq $OpenAuthenticode) {
Install-Module OpenAuthenticode -Force -Scope CurrentUser -AllowClobber
Expand All @@ -8,8 +14,7 @@ if ($null -eq $OpenAuthenticode) {
$key = Get-OpenAuthenticodeAzKey -Vault ims-hms2 -Certificate Global-Sign-Cert -ErrorAction SilentlyContinue

if ($null -eq $Key) {
Write-Warning "No signing key available. Skipping signing."
return
throw "Code signing was requested, but no signing key is available."
}

$signParams = @{
Expand Down
Loading