Conversation
lprnmns
marked this pull request as ready for review
August 31, 2026 14:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
makeRe() could generate a character-class regexp that matched a path separator even though minimatch() correctly treats / as a path boundary. For example, makeRe('[^a]').test('/') returned true while minimatch('/', '[^a]') returned false; the same mismatch occurred after a wildcard and with a POSIX class.
Fix
Parsed character classes now reject / at each class position. The AST start check accounts for the zero-width guard so existing dotfile and traversal protections remain unchanged.
Tests
Compatibility
This narrows only the makeRe() false-positive path. It aligns generated regular expressions with existing per-path-portion minimatch() behavior; regex source snapshots change accordingly. No package API, dependency, or version change was made.
Related issue
Independent current-branch reproduction; no issue is linked. The final collision check found open PRs for other current minimatch defects, but none for this character-class/path-separator mismatch.