Repository navigation
feastdate 1.0.6: a feria with a weekday feast is its weekday, not an offset - #12
Merged
Merged
Conversation
…offset
"Feria 6 in Parasceve 1680" answered Wed 14 Apr, five days after Good
Friday, and "Feria V in Coena Domini" answered the Monday after Maundy
Thursday. In these names the feria is the feast's own weekday (feria 1
is Sunday), so the count from the feast is right only when the feast is
a Sunday.
With Maundy Thursday, Good Friday and Ascension the feria is now a check:
the matching number resolves to the feast itself and any other is
refused ("feria 2 does not fall on ascens, a Thursday"). Sunday feasts
count as before. quinta, sexta and septima are read as ordinals, so
"Feria sexta in Parasceve" works as written.
Fixes #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Feria 6 in Parasceve 1680" answered Wed 14 Apr, five days after Good
Friday, and "Feria V in Coena Domini" answered the Monday after Maundy
Thursday. In these names the feria is the feast's own weekday (feria 1
is Sunday), so the count from the feast is right only when the feast is
a Sunday.
With Maundy Thursday, Good Friday and Ascension the feria is now a check:
the matching number resolves to the feast itself and any other is
refused ("feria 2 does not fall on ascens, a Thursday"). Sunday feasts
count as before. quinta, sexta and septima are read as ordinals, so
"Feria sexta in Parasceve" works as written.
Tests: the three inputs from the issue, plus the spelled-out ordinals and a wrong feria against each weekday feast. 272 passed.
Fixes #3