gen-release-notes: fix pagination when listing PR files - #3422
Open
potsju wants to merge 1 commit into
Open
Conversation
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
😊 Welcome @potsju! This is either your first contribution to the Istio tools repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/M
potsju
force-pushed
the
fix-release-notes-pr-file-pagination
branch
from
July 2, 2026 05:09
c033c3b to
c00b062
Compare
The tool was using `gh pr view --json=files` to get the list of files changed in a PR, but that command only returns the first page of results (around 100 files) and doesn't fetch the rest. On PRs bigger than that, files near the end of the list get silently dropped, including release note files, which caused false "missing release notes" errors on large PRs. Example: istio/istio#60755 Switched to calling GitHub's paginated REST API directly, which keeps fetching pages until it has the full file list, no matter how big the PR is.
potsju
force-pushed
the
fix-release-notes-pr-file-pagination
branch
from
July 2, 2026 05:11
c00b062 to
b8c5efe
Compare
Contributor
|
Hey, I'll make some room to test the changes this week. Thanks a lot for checking this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tool was using
gh pr view --json=filesto get the list of files changed in a PR, but that command only returns the first page of results (around 100 files) and doesn't fetch the rest. On PRs bigger than that, files near the end of the list get silently dropped, including release note files, which caused false "missing release notes" errors on large PRs.Example: istio/istio#60755
Switched to calling GitHub's paginated REST API directly, which keeps fetching pages until it has the full file list, no matter how big the PR is.