Skip to content

Drop --defsym in al-core.pc when not accepted #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimonPinches wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Drop --defsym in al-core.pc when not accepted #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,14 @@ target_include_directories(
)

# Generate and install .pc file
# Stamp the AL version into consuming binaries via a linker-defined symbol.
# --defsym is specific to GNU-compatible linkers: Apple's ld64 and MSVC's
# link.exe reject it, so only emit the flag where it is supported.
if(APPLE OR WIN32)
set(AL_PC_VERSION_SYMBOL_FLAG "")
else()
set(AL_PC_VERSION_SYMBOL_FLAG " -Wl,--defsym,AL_VER_${PROJECT_VERSION}=0")
endif()
configure_file(pkgconfig/al-core.pc.in al-core.pc @ONLY)
include(GNUInstallDirs)
install(
Expand Down
2 changes: 1 addition & 1 deletion pkgconfig/al-core.pc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ Version: @PROJECT_VERSION@
Description: IMAS Access Layer core libraries for C.
URL: https://imas.iter.org
Cflags: -I${includedir}
Libs: -L${libdir} -lal -Wl,--defsym,AL_VER_@PROJECT_VERSION@=0 -Wl,-rpath,${libdir}
Libs: -L${libdir} -lal@AL_PC_VERSION_SYMBOL_FLAG@ -Wl,-rpath,${libdir}
Loading