Skip to content

feat(icon): Add institution-valid and institution-none icons - #1477

Open
joiechang wants to merge 4 commits into
developfrom
institution-icons-add
Open

feat(icon): Add institution-valid and institution-none icons#1477
joiechang wants to merge 4 commits into
developfrom
institution-icons-add

Conversation

@joiechang

@joiechang joiechang commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?

What does this change address?
Closes Issue 1476

How does this change work?

  • adds the two icons

Additional context
N/A

@changeset-bot

changeset-bot Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c07edfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
packages/pharos/lib/index.js 56.42 KB (0%)

@joiechang joiechang linked an issue Oct 23, 2026 that may be closed by this pull request
Icon: Add institution-valid and institution-none #1476
Open
@joiechang joiechang changed the title Update icons.json feat(icon): Add institution-valid and institution-none icons Oct 23, 2026
@joiechang
joiechang marked this pull request as ready for review October 23, 2026 20:33
@joiechang
joiechang requested a review from a team as a code owner October 23, 2026 20:33
@joiechang
joiechang requested review from daneah, lizlove and shoupeva-ithaka and removed request for a team October 23, 2026 20:33
@joiechang

joiechang commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Looks like we have a test to prevent two color, hardcoded color icons:

x packages/pharos/assets/icons/institution-none.svg
x custom-2 1:0 Fill value '#C61515' should only be present if this part of th
e icon's color is not meant to be controlled by the consumer.
If you're sure this icon is using fill attributes appropriatel
y, add it to the fillAllowList in .svglintrc.js.
At node (1:0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daneah daneah Awaiting requested review from daneah daneah is a code owner automatically assigned from ithaka/pharos-maintainers
@lizlove lizlove Awaiting requested review from lizlove lizlove is a code owner automatically assigned from ithaka/pharos-maintainers
@shoupeva-ithaka shoupeva-ithaka Awaiting requested review from shoupeva-ithaka shoupeva-ithaka is a code owner automatically assigned from ithaka/pharos-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Icon: Add institution-valid and institution-none

1 participant

@joiechang