Skip to content

added dark theme for html reporter#555

Merged
redcatbear merged 3 commits into
itsallcode:mainfrom
Davidius86:feature/add_dark_theme_to_html_reporter
Jul 11, 2026
Merged

added dark theme for html reporter#555
redcatbear merged 3 commits into
itsallcode:mainfrom
Davidius86:feature/add_dark_theme_to_html_reporter

Conversation

@Davidius86

Copy link
Copy Markdown
Contributor

This PR adds colors for dark theme to css file of the html reporter.

@redcatbear

Copy link
Copy Markdown
Collaborator

I like the dark theme and especially that you used a CSS selector as switch instead of adding Java script. I tweaked the color a bit for more contrast to hopefully improve the accessibility for users with visual impairments.

Comment thread reporter/html/src/main/resources/css/report.css Outdated
Comment thread reporter/html/src/main/resources/css/report.css Outdated
Comment thread reporter/html/src/main/resources/css/report.css Outdated
Comment thread reporter/html/src/main/resources/css/report.css Outdated
Comment thread reporter/html/src/main/resources/css/report.css Outdated
Comment thread reporter/html/src/main/resources/css/report.css Outdated
Comment thread reporter/html/src/main/resources/css/report.css Outdated
Comment thread reporter/html/src/main/resources/css/report.css
@Davidius86 Davidius86 marked this pull request as draft July 10, 2026 20:03
@Davidius86

Copy link
Copy Markdown
Contributor Author

Changed to draft to check the new colors.

@redcatbear

Copy link
Copy Markdown
Collaborator

Sure thing. See if you like it. It's your PR after all. :-)

Davidius86 and others added 2 commits July 11, 2026 11:18
Co-authored-by: Sebastian Bär <sebastian.baer@exasol.com>
@Davidius86 Davidius86 force-pushed the feature/add_dark_theme_to_html_reporter branch from 8c21a98 to ac1932b Compare July 11, 2026 09:18
@Davidius86

Copy link
Copy Markdown
Contributor Author

PR rebased. Colors look good

@Davidius86 Davidius86 marked this pull request as ready for review July 11, 2026 09:20
@redcatbear

Copy link
Copy Markdown
Collaborator

Thank you, @Davidius86. Please remove the remaining todo markers and then we can merge.
Also, please add this feature to the release letter. After that, I will merge the PR.

@redcatbear redcatbear merged commit 4b8b360 into itsallcode:main Jul 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants