Repository navigation
ci: record the shipped build number in the release commit - #156
Merged
Merged
Conversation
Changie stamps only the marketing version, so local builds after a release reported the new version with the previous build number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the move to Changie, the release commit recorded only the marketing version. After a release, local builds would have reported the new version with the previous release's build number. This brings back the old behavior: the release commit also records the shipped build number (the commit count), using
xcrun xcodeproj setting set CURRENT_PROJECT_VERSION(Apple's tool, which keepsproject.xcprojcanonical). Release builds are unaffected, because they always get the build number on the command line.Tested by running the write-back on a scratch copy of the project file. The release workflow's record step hasn't been run end to end.