Repository navigation
feat(api-client): unsaved-changes dot and Cmd+S save in place - #421
Merged
Merged
Conversation
Tabs opened from (or saved into) a collection now remember their request. A dot replaces the close button while the tab differs from what was saved; Cmd+S overwrites that request in place (DB and folder collections), or opens Save for drafts and requests deleted since. Failed saves keep the dot so the next Cmd+S retries. - Folder defaults (headers/auth/scripts) are merged at send, cURL copy and codegen time via withFolderDefaults instead of being baked into the tab on load, so saving never writes them back into the request. - Opening a request that is already open focuses its tab. - Save-as now keeps pre-request/test scripts, timeout and cookie-jar setting. Examples and comments are not written by Cmd+S (tabs may hold quota-stripped copies); stripped form-data file bytes are restored from the stored request. - Duplicated tabs are unlinked drafts; URL edits no longer rename a saved request's tab. - saveRequest resolves with success; patchFolder generalised to patchItem, adding updateRequest. - i18n: shortcuts.saveRequest, tabBar.unsavedChanges in all 27 locales. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase A, item A8 of the API Client plan.
sourceandsavedFingerprinton the tab).Behaviour change: folder defaults are applied at send time
Opening a request used to copy its folder's default headers, auth and scripts into the tab. If ⌘S saved that back, the folder defaults would be written into the request and folder scripts would run twice. Now
withFolderDefaultsmerges them when sending, copying cURL and generating code. The trade-off is that inherited headers no longer appear in the tab's Headers list.Fixes along the way
Not in this PR
Test plan
tsc --noEmitpassessaved-requesttests for the dirty check, save patch and folder defaults🤖 Generated with Claude Code