chore: replace deprecated argument writeable to writable in IO::Memory.new() - #5698
chore: replace deprecated argument writeable to writable in IO::Memory.new()#5698Fijxu wants to merge 1 commit into
writeable to writable in IO::Memory.new()#5698Conversation
…emory.new() Crystal 1.21.0 replaces `IO::Memory.new` argument `writeable` to `writable`: crystal-lang/crystal#16858 This PR can wait until we no longer support Crystal <1.21.0
327b0ae to
96b8f69
Compare
|
Warning Review limit reached
Next review available in: 43 minutes Limit details: You’ve used all 3 included reviews currently available under your plan. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
Crystal 1.21.0 replaces
IO::Memory.newargumentwriteabletowritable: crystal-lang/crystal#16858This PR can wait until we no longer support Crystal <1.21.0
Greptile Summary
Updates the
IO::Memorykeyword used to wrap cached static-file bytes for Crystal 1.21.0 compatibility. The potential cached byte-range regression was disproved: the focused static-assets tests passed all 8 examples, including caching a file from an initial range request and serving later ranges from cached bytes. Direct runtime checks also confirmed that the updated constructor remains read-only: reads succeed and writes raiseIO::Error.Confidence Score: 5/5
Safe to merge based on the exercised cached static-file range behavior.
The updated Crystal 1.21.0 constructor compiled and retained the prior read-only behavior, while focused runtime coverage passed for cached responses, byte ranges, multipart ranges, compression, and cache limits.
Files Needing Attention: No files need further attention.
What T-Rex did
Reviews (1): Last reviewed commit: "chore: replace deprecated argument `writ..." | Re-trigger Greptile