Skip to content

chore: replace deprecated argument writeable to writable in IO::Memory.new() - #5698

Open
Fijxu wants to merge 1 commit into
iv-org:masterfrom
Fijxu:deprecation-of-writeable-argument-in-IO-memory-new
Open

chore: replace deprecated argument writeable to writable in IO::Memory.new()#5698
Fijxu wants to merge 1 commit into
iv-org:masterfrom
Fijxu:deprecation-of-writeable-argument-in-IO-memory-new

Conversation

@Fijxu

@Fijxu Fijxu commented Apr 28, 2026

Copy link
Copy Markdown
Member

Crystal 1.21.0 replaces IO::Memory.new argument writeable to writable: crystal-lang/crystal#16858

This PR can wait until we no longer support Crystal <1.21.0

Greptile Summary

Updates the IO::Memory keyword used to wrap cached static-file bytes for Crystal 1.21.0 compatibility. The potential cached byte-range regression was disproved: the focused static-assets tests passed all 8 examples, including caching a file from an initial range request and serving later ranges from cached bytes. Direct runtime checks also confirmed that the updated constructor remains read-only: reads succeed and writes raise IO::Error.

Confidence Score: 5/5

Safe to merge based on the exercised cached static-file range behavior.

The updated Crystal 1.21.0 constructor compiled and retained the prior read-only behavior, while focused runtime coverage passed for cached responses, byte ranges, multipart ranges, compression, and cache limits.

Files Needing Attention: No files need further attention.

T-Rex T-Rex Logs

What T-Rex did

  • Ran the Crystal 1.21.0 review harness to compare IO::Memory.new(bytes, writeable: false) with IO::Memory.new(bytes, writable: false) and executed the static assets handler spec with -Drunning_by_self.
  • Validated that both constructor forms read cached bytes and reject writes with IO::Error, confirming the updated keyword preserves the checked cached byte-range behavior.
  • Collected the evidence artifacts showing baseline and PR behavior, including the authored evidence harness script.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "chore: replace deprecated argument `writ..." | Re-trigger Greptile

…emory.new()

Crystal 1.21.0 replaces `IO::Memory.new` argument `writeable` to `writable`: crystal-lang/crystal#16858

This PR can wait until we no longer support Crystal <1.21.0
@Fijxu
Fijxu force-pushed the deprecation-of-writeable-argument-in-IO-memory-new branch from 327b0ae to 96b8f69 Compare August 17, 2026 05:56
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Fijxu, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Limit details: You’ve used all 3 included reviews currently available under your plan.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 830ce397-3c68-45cd-8ee4-99902c1712d8

📥 Commits

Reviewing files that changed from the base of the PR and between 821365c and 96b8f69.

📒 Files selected for processing (1)
  • src/invidious/http_server/static_assets_handler.cr

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants