fix: ADC Local Test Run 5 defects (Common side) - #498
Merged
Merged
Conversation
- OAuth: read urn:github:name before ClaimTypes.Name (GitHub login handle); never pass an empty last name (first GitHub sign-up failed, U-15/A-46) - Login: read ?error= and show a localized alert (U-15) - TermsAcceptanceGate: dialog survives navigation (A-45) - MainLayout: skip link stays on the current page, main region focusable, visible nav-link focus ring (X-03) - BiometricGate: sign-out goes through the app logout path (A-22) - MAUI speech/share/screenshot/media picker: any non-cancellation failure returns the contract's null/false; speech runs on the main thread (A-11, A-08, A-01/X-27) - Notifications: live leg carries scopeKey; listener skips toast/badge for another scope (OBS-7) - QrCodeImage shrinks to its container (OBS-9) - RegistrationSettings.CollectAddress (default true, section "Registration") hides the Register address block when off (U-21) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sDGvYdTD88ZjjD7if2SMW
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common-side fixes for the defects verified in ADC Local Test Run 5. Tests were written first by a separate pass (failing on main for each defect's own reason), then the fixes.
OAuthControllerBasereadsurn:github:namebeforeClaimTypes.Name(GitHub's login handle) and never passes an empty last name (placeholder "User"); every first GitHub sign-up failedUser.LastName.Empty?error=and shows a localized alert (en + es)TermsAcceptanceGatedialog setsCloseOnNavigation = false, so a list page's URL rewrite no longer dismisses it#main-contenthastabindex=-1,.mud-nav-link:focus-visibleoutlineBiometricGatesign-out callsIAuthUIService.LogoutAsync(auth state + caches cleared)scopeKey;NotificationListenerskips toast/badge for another scopeQrCodeImagemax-width 100%, height autoRegistrationSettings.CollectAddress(default true, sectionRegistration) hides the Register address block when off; Store/Helpdesk unchangedExisting tests changed: three
InlineDatarows ofCompleteAsync_ExtractsNameFromClaimsWithFullNameFallbackthat pinned the empty last name now expect "User"; setup-only DI additions inBiometricGateTestsandNotificationListenerTests.Local:
MMCA.Common.slnxDebug build 0 warnings; all unit test exes Failed: 0 (API 869, UI 1248, Application 1318, Architecture 318, plus the rest);MMCA.Common.UI.Mauibuilds for android and windows.🤖 Generated with Claude Code
https://claude.ai/code/session_012sDGvYdTD88ZjjD7if2SMW