docs(capabilities): login-protection counters are not atomic - #236
Merged
Merged
Conversation
The brute-force section called the counters atomic; LoginProtectionService documents a read-modify-write increment as an accepted trade-off. Found by ADC Local Test Run 5 (U-23). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sDGvYdTD88ZjjD7if2SMW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common-CAPABILITIES.mdcalled the login-protection counters "cache-backed atomic counters".LoginProtectionService.IncrementFailedAttemptsAsyncdocuments a read-modify-write increment as an accepted trade-off, so the guide now says that sequential guessing trips the limits and a burst of truly concurrent attempts can slip under them.Found by ADC Local Test Run 5 (U-23). Render regenerated with
npm run build.🤖 Generated with Claude Code
https://claude.ai/code/session_012sDGvYdTD88ZjjD7if2SMW