Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions message.go
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,8 @@ type InsertMessage struct {

// Decode decodes to message from src.
func (m *InsertMessage) Decode(src []byte) error {
if len(src) < 8 {
return m.lengthError("InsertMessage", 8, len(src))
if len(src) < 7 {
return m.lengthError("InsertMessage", 7, len(src))
}

var low, used int
Expand Down
4 changes: 2 additions & 2 deletions messageV2.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ func (m *InsertMessageV2) DecodeV2(src []byte, inStream bool) (err error) {
return m.InsertMessage.Decode(src)
}

if len(src) < 12 {
return m.lengthError("InsertMessageV2", 12, len(src))
if len(src) < 11 {
return m.lengthError("InsertMessageV2", 11, len(src))
}

src = readXidAndAdvance(src, &m.InStreamMessageV2WithXid, inStream)
Expand Down
23 changes: 23 additions & 0 deletions messageV2_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,29 @@ func (s *insertMessageV2Suite) TestNoStream() {
s.Equal(expected, &insertMsg.InsertMessage)
}

func (s *insertMessageV2Suite) TestNoColumns() {
msg, expected := s.createInsertTestDataNoColumns()
msgV2, xid := s.insertXid(msg)

m, err := ParseV2(msgV2, true)
s.NoError(err)
insertMsg, ok := m.(*InsertMessageV2)
s.True(ok)
s.Equal(xid, insertMsg.Xid)
s.Equal(expected, &insertMsg.InsertMessage)
}

func (s *insertMessageV2Suite) TestNoColumnsNoStream() {
msg, expected := s.createInsertTestDataNoColumns()

m, err := ParseV2(msg, false)
s.NoError(err)
insertMsg, ok := m.(*InsertMessageV2)
s.True(ok)
s.Equal(uint32(0), insertMsg.Xid)
s.Equal(expected, &insertMsg.InsertMessage)
}

func TestUpdateMessageV2Suite(t *testing.T) {
suite.Run(t, new(updateMessageV2Suite))
}
Expand Down
29 changes: 29 additions & 0 deletions message_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,24 @@ func (s *messageSuite) createInsertTestData() ([]byte, *InsertMessage) {
return msg, expected
}

func (s *messageSuite) createInsertTestDataNoColumns() ([]byte, *InsertMessage) {
relationID := s.newRelationID()

msg := make([]byte, 1+4+1+2)
msg[0] = 'I'
bigEndian.PutUint32(msg[1:], relationID)
msg[5] = 'N'
bigEndian.PutUint16(msg[6:], 0)

expected := &InsertMessage{
RelationID: relationID,
Tuple: &TupleData{},
}
expected.msgType = 'I'

return msg, expected
}

func (s *messageSuite) createUpdateTestDataTypeK() ([]byte, *UpdateMessage) {
relationID := s.newRelationID()

Expand Down Expand Up @@ -736,6 +754,17 @@ func (s *insertMessageSuite) Test() {
s.Equal(expected, insertMsg)
}

func (s *insertMessageSuite) TestNoColumns() {
msg, expected := s.createInsertTestDataNoColumns()

m, err := Parse(msg)
s.NoError(err)
insertMsg, ok := m.(*InsertMessage)
s.True(ok)

s.Equal(expected, insertMsg)
}

func TestUpdateMessageSuite(t *testing.T) {
suite.Run(t, new(updateMessageSuite))
}
Expand Down
Loading