Repository navigation
Swap wishlist and favourite icons: bookmark for wishlist, heart for roaster favourites - #23
Merged
Merged
Conversation
… heart for favourites
The bean wishlist used a red ♥/♡ heart and roaster favourites used a
bookmark — inverted semantics. A wishlist is "buy this later" (with
restock alerts attached): a bookmark, the same glyph Vivino and Untappd
use for "want". Pinning a roaster is affection: that's the heart.
- WishlistHeart: bookmark SVG from the shared Icon set instead of a
text glyph; accent colour instead of red so it matches the rest of
the UI; adds aria-label to match FavoriteRoasterButton.
- FavoriteRoasterButton, the "Pinned" directory filter, and the
account-page hint: heart.
- Wishlist nav tab and empty-state hint: bookmark.
No behaviour change; labels ("Add to wishlist", "Pin X") unchanged.
Adds a WishlistHeart test (it had none) covering the toggle, the glyph
choice, click containment and the signed-out state.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WQPoqZvpFtcjR76PFyVv99
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jameshiggins
marked this pull request as ready for review
September 24, 2026 20:22
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Swaps the two "save" icons so they match what each action means.
Touch points
WishlistHeart.jsx— bookmark SVG from the sharedIconset instead of a text glyph; accent colour instead of red so it sits with the rest of the UI; addsaria-label(matchesFavoriteRoasterButton). Component name kept to keep the diff small; rename is cosmetic and can follow.FavoriteRoasterButton.jsx, the Pinned filter chip on the roaster directory, and the account-page "Nothing pinned yet" hint → heart.♡character).No behaviour or label changes ("Add to wishlist", "Pin X" are unchanged), so existing tests pass untouched.
Tests
New
WishlistHeart.test.jsx— the component had none: accessible pressed/unpressed toggle, add vs. remove, click doesn't bubble to the card, hidden when signed out, and a guard that it renders an SVG rather than a ♥/♡ and isn't red.Lint 0 errors, typecheck clean, 338 tests passing (+6), build clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WQPoqZvpFtcjR76PFyVv99
Generated by Claude Code