Skip to content

Fixing axis labelling issues - #461

Open
julianwuth wants to merge 4 commits into
jasp-stats:masterfrom
julianwuth:fix-histogram
Open

Fixing axis labelling issues#461
julianwuth wants to merge 4 commits into
jasp-stats:masterfrom
julianwuth:fix-histogram

Conversation

@julianwuth

Copy link
Copy Markdown

There were some problems with the x-axis labels for the histogram of the residuals in DOE.

This is fixed by:

  • Using jaspGraphs::jaspHistogram
  • Updating snapshots accordingly
  • Additionally, the binwidth method now carries over to the matrix plot.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes residual histogram x-axis labeling in the DOE analysis outputs by switching to jaspGraphs::jaspHistogram, and aligns the matrix residual plot’s histogram behavior (incl. binwidth settings) with the standalone histogram.

Changes:

  • Replace jaspDescriptives::.plotMarginal() with jaspGraphs::jaspHistogram() for the residuals histogram.
  • Propagate histogram binwidth options to the matrix residual plot via updated $dependOn().
  • Update vdiffr SVG snapshots for the affected plots.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.

File Description
R/doeAnalysis.R Uses jaspGraphs::jaspHistogram() for residual histograms and adds histogram binwidth options to matrix plot dependencies.
tests/testthat/_snaps/doeAnalysis/histogram-of-residuals27.svg Snapshot updated to match the new histogram rendering/axis labeling.
tests/testthat/_snaps/doeAnalysis/matrix-residual-plot27-subplot-3.svg Snapshot updated for the histogram subplot in the 2x2 residual matrix plot.

Comment thread R/doeAnalysis.R Outdated
Comment thread R/doeAnalysis.R Outdated
@JTPetter

Copy link
Copy Markdown
Contributor

Looks good to me! Copilot added some gettext() around strings, which I committed. Maybe wait for #466 to be merged and then rebase, so we can see if the unit tests run fine.

@JTPetter

Copy link
Copy Markdown
Contributor

@julianwuth can you rebase / rerun the unit tests?

julianwuth and others added 3 commits August 9, 2026 11:34
There were some problems with the x-axis labels for the histogram of the residuals in DOE.

This is fixed by:
- Using jaspGraphs::jaspHistogram
- Updating snapshots accordingly
- Additionally, the binwidth method now carries over to the matrix plot.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov-commenter

codecov-commenter commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.45%. Comparing base (5adc0f5) to head (850ce68).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   84.44%   84.45%           
=======================================
  Files          18       18           
  Lines       10513    10515    +2     
=======================================
+ Hits         8878     8880    +2     
  Misses       1635     1635           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julianwuth

Copy link
Copy Markdown
Author

@julianwuth can you rebase / rerun the unit tests?

@JTPetter I rebased, but unit tests seem to fail on macOS. I tried to fix it but could not find a quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants