Fixing axis labelling issues - #461
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes residual histogram x-axis labeling in the DOE analysis outputs by switching to jaspGraphs::jaspHistogram, and aligns the matrix residual plot’s histogram behavior (incl. binwidth settings) with the standalone histogram.
Changes:
- Replace
jaspDescriptives::.plotMarginal()withjaspGraphs::jaspHistogram()for the residuals histogram. - Propagate histogram binwidth options to the matrix residual plot via updated
$dependOn(). - Update vdiffr SVG snapshots for the affected plots.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
R/doeAnalysis.R |
Uses jaspGraphs::jaspHistogram() for residual histograms and adds histogram binwidth options to matrix plot dependencies. |
tests/testthat/_snaps/doeAnalysis/histogram-of-residuals27.svg |
Snapshot updated to match the new histogram rendering/axis labeling. |
tests/testthat/_snaps/doeAnalysis/matrix-residual-plot27-subplot-3.svg |
Snapshot updated for the histogram subplot in the 2x2 residual matrix plot. |
|
Looks good to me! Copilot added some gettext() around strings, which I committed. Maybe wait for #466 to be merged and then rebase, so we can see if the unit tests run fine. |
|
@julianwuth can you rebase / rerun the unit tests? |
There were some problems with the x-axis labels for the histogram of the residuals in DOE. This is fixed by: - Using jaspGraphs::jaspHistogram - Updating snapshots accordingly - Additionally, the binwidth method now carries over to the matrix plot.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4380fac to
16f6122
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
=======================================
Coverage 84.44% 84.45%
=======================================
Files 18 18
Lines 10513 10515 +2
=======================================
+ Hits 8878 8880 +2
Misses 1635 1635 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
@JTPetter I rebased, but unit tests seem to fail on macOS. I tried to fix it but could not find a quick fix. |
There were some problems with the x-axis labels for the histogram of the residuals in DOE.
This is fixed by: