Theme support - #231
Open
aryxs3m wants to merge 1 commit into
Open
Conversation
|
Someone is attempting to deploy a commit to the jdan's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a browser game with 98.css and tried to find a way to let users customize their desktop.
I disabled
postcss-css-variablesto get variables back in the build, then i added classes to thethemes.cssbased on the default color schemes from a Windows 98 SE VM.The results can be seen here; try the theme selector. High contrast themes are not perfect but the other ones are pretty close to the originals. Enabling a theme is just as easy as adding a CSS class to the body/html tag, e.g.
theme-brick.For coloring the controls I removed some of the default fills from the SVGs and added extra background color CSS.