Repository navigation
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
+ Coverage 89.16% 89.64% +0.47%
==========================================
Files 116 116
Lines 13406 13438 +32
==========================================
+ Hits 11954 12046 +92
+ Misses 1452 1392 -60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mmore500
requested changes
Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was prepared and tested by an AI coding agent under standing instructions. Anthony has not reviewed the code line by line.
TreeSummarizer.tree_from_splitsraisesTypeErrorwhen ordinary input trees omit their optional root lengths.SplitDistributionrecords those lengths asNone, and both mean-calculation loops try to subtract them.Keep a consensus edge undefined when any sampled length is missing, matching the existing split-summary behavior, while retaining means for complete numeric samples. Apply the same guard to both loops. As requested in review, use
None not in edgesand emit one standardUserWarningper call when a returned consensus edge has missing length samples. Fully defined samples, support-only construction and excluded splits do not warn. Add regressions for omitted/mixed lengths, defined zero/negative lengths, single observations, input non-mutation and support-only construction.Validation after review: all 14 consensus tests pass on Python 3.8 and 3.12; all 164 smoke tests and
lint.shpass. The full unit run has 989 passes and four PAUP execution failures (PermissionError), all four reproduced on unchanged main. On the bundled pythonidae and cetacean posterior datasets, 18 formerly failing summary/export workflows now work per profile, including full-dataset cases; all 36 complete controls remain exact. Exported topology, internal support labels and defined lengths round-trip, and 1,008 continued tip-distance calculations agree with independent parent-path sums. The original installed wheel reproduced all 54 complete reports. The review revision reproduces those exact outputs from source and emits exactly 18 missing-length warnings across the 54 calls.