Repository navigation
build: target Android 16 (API 36) - #595
Merged
Merged
Conversation
Play rejects updates that don't target API 36, and on 2026-11-17 it refused the latest bundle on the closed testing track as well, so the requirement isn't limited to production. targetSdk 35 -> 36 in app and benchmark. The Android 16 changes for target-36 apps (no edge-to-edge opt-out, predictive back by default, orientation/resize limits ignored on large screens, elegantTextHeight) were checked against the code; none needed a fix. Checked on an API 36 AVD: edge-to-edge, back order, large-screen layout, all 71 instrumented tests, and the sideload update handoff to the system installer. Refs #262 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2 of
docs/TARGET_API_36_EVALUATION.md(PR 1, the build tools, was #591).Why now
On 2026-11-17 a signed bundle of the current release (vc190, target 35) was uploaded to Play's closed testing (Alpha) track. The upload passed, but the review step refused it with "must target API level 36 or higher" and Save stayed disabled. The requirement covers testing tracks, not only production. That draft is still on the Alpha track, and vc190 is now taken in Play, so the next Play build needs vc191 or later.
Change
targetSdk35 → 36 inappandbenchmark.minSdkstays 26, so the devices Markleaf installs on don't change.BackHandler, there's no orientation or resize limit, andelegantTextHeightisn't used.Checks
Local, Windows
testDebugUnitTest: 1496 tests, 3 failures, all inEditorPreviewFindTestandEditorSurvivesRotationTest. PR 1 already recorded these two classes as intermittent in a full Windows run. Both are pinned tosdk = [33], so this change doesn't reach them, and they pass when run alone (9/9).lintRelease: 0 errors.assembleDebugand:benchmark:assemblepass.targetSdkVersion 36and has the same permissions as before.API 36 AVD
SingleNoteWidgetRenderTestincluded. CI runs them on API 30 ATD, so this is their only API 36 run.-Pmarkleaf.updater=truebuild with versionCode temporarily set to 189 (not committed). It fetched the realupdate.jsonand walked through banner → download → the install-unknown-apps permission → the system installer → "App installed · Done / Open".logcat -b crash.Not checked: the S24 refused wireless ADB, so there was no real-device run. The widget
setRemoteAdapterdeprecations are left as they are.Refs #262