Skip to content

build: target Android 16 (API 36) - #595

Merged
jeiel85 merged 1 commit into
mainfrom
build/target-sdk-36
Nov 18, 2026
Merged

jeiel85 merged 1 commit into
mainfrom
build/target-sdk-36

Conversation

@jeiel85

@jeiel85 jeiel85 commented Nov 17, 2026

Copy link
Copy Markdown
Owner

PR 2 of docs/TARGET_API_36_EVALUATION.md (PR 1, the build tools, was #591).

Why now

On 2026-11-17 a signed bundle of the current release (vc190, target 35) was uploaded to Play's closed testing (Alpha) track. The upload passed, but the review step refused it with "must target API level 36 or higher" and Save stayed disabled. The requirement covers testing tracks, not only production. That draft is still on the Alpha track, and vc190 is now taken in Play, so the next Play build needs vc191 or later.

Change

  • targetSdk 35 → 36 in app and benchmark. minSdk stays 26, so the devices Markleaf installs on don't change.
  • The Android 16 changes for target-36 apps were checked against the code. None needed a fix: there's no edge-to-edge opt-out, predictive back is already opted in and uses BackHandler, there's no orientation or resize limit, and elegantTextHeight isn't used.
  • CHANGELOG (en/ko) Unreleased → Changed, HISTORY, evaluation doc.

Checks

Local, Windows

  • testDebugUnitTest: 1496 tests, 3 failures, all in EditorPreviewFindTest and EditorSurvivesRotationTest. PR 1 already recorded these two classes as intermittent in a full Windows run. Both are pinned to sdk = [33], so this change doesn't reach them, and they pass when run alone (9/9).
  • lintRelease: 0 errors. assembleDebug and :benchmark:assemble pass.
  • The debug APK reads targetSdkVersion 36 and has the same permissions as before.

API 36 AVD

  • Edge-to-edge: the bars and the row above the keyboard sit in place.
  • Back: it closes the keyboard, then the formatting panel, then the editor (the note is saved), then leaves the app.
  • Large screen: at 1600×2560 / 320 dpi, landscape shows three panes and portrait shows one, with no letterboxing.
  • Instrumented tests: all 71 pass, SingleNoteWidgetRenderTest included. CI runs them on API 30 ATD, so this is their only API 36 run.
  • Sideload update (D079): I used a -Pmarkleaf.updater=true build with versionCode temporarily set to 189 (not committed). It fetched the real update.json and walked through banner → download → the install-unknown-apps permission → the system installer → "App installed · Done / Open".
  • No crashes in logcat -b crash.

Not checked: the S24 refused wireless ADB, so there was no real-device run. The widget setRemoteAdapter deprecations are left as they are.

Refs #262

Play rejects updates that don't target API 36, and on 2026-11-17 it
refused the latest bundle on the closed testing track as well, so the
requirement isn't limited to production.

targetSdk 35 -> 36 in app and benchmark. The Android 16 changes for
target-36 apps (no edge-to-edge opt-out, predictive back by default,
orientation/resize limits ignored on large screens, elegantTextHeight)
were checked against the code; none needed a fix. Checked on an API 36
AVD: edge-to-edge, back order, large-screen layout, all 71 instrumented
tests, and the sideload update handoff to the system installer.

Refs #262

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T15:10:51.961317Z 2fca9c2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jeiel85
jeiel85 merged commit 8314943 into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant