Skip to content

feat: select several notes at once in the list, archive and trash (#596) - #597

Merged
jeiel85 merged 1 commit into
mainfrom
feat/batch-selection-596
Nov 18, 2026
Merged

jeiel85 merged 1 commit into
mainfrom
feat/batch-selection-596

Conversation

@jeiel85

@jeiel85 jeiel85 commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Implements the idea from Discussion #596 (@jardrog): act on several notes at once.

What changes

  • Notes list. Long-press → Select (new first item of the one-note menu), or ⋮ → Select notes. While selecting, a tap picks a note instead of opening it. The bar: Pin/Unpin (Pin if any picked note is unpinned), Archive, Move to trash, and under ⋮ Select all and Move to Locked (same passcode prompt and sync-folder cleanup as one note). ✕ or Back ends it.
  • Archive. Select from the long-press menu; bar with Select all, Unarchive, Move to trash.
  • Trash. A row has no menu, so a long press starts the selection. Restore and Delete forever (dialog with the count; deletes exactly the notes it counted, as Empty trash does since Feature Request: Trash All Button #566). Outside a selection the row is unchanged: a tap does nothing and its own buttons stay separate targets.
  • Undo. Moving to the trash from the list or the archive — one note or several — shows a snackbar with Undo (restores under TrashPurge.lock).
  • Repository. Collection overloads on NoteRepository (default bodies loop the one-note call, so fakes need no change); LocalNoteRepository runs them in one withTransaction so the list redraws once.
  • Strings in all 11 languages; CHANGELOG (en/ko) and HISTORY.

Long-press keeps opening the menu, so nothing changes for anyone who doesn't use Select. Bulk tagging is not included (a tag is text in each note; it is listed under Limits and left open in the Discussion).

Checks

  • New: NotesListSelectionTest (7), ArchiveAndTrashSelectionTest (4), LocalNoteRepositoryTest +1.
  • Full testDebugUnitTest on Windows: 1508 tests, 2 failures in EditorPreviewFindTest / EditorSurvivesRotationTest (known intermittent in full Windows runs, pass alone). lintRelease passes.
  • AVD markleaf-phone-api36: list selection, trash + Undo, trash-screen selection and restore, archive selection and unarchive. No crash in logcat -b crash.
  • No Roborazzi golden covers these screens.

Refs #596

Long-press a note and choose Select, or pick Select notes from the
overflow menu, then tap more notes. The bar acts on all of them: pin or
unpin, archive, move to trash, select all, move to Locked. The archive
gets Unarchive and Move to trash; in the trash a long press starts the
selection, with Restore and Delete forever (asks first, with the count).
Long-press still opens the one-note menu, so nothing changes until Select
is used. Back or the close button ends the selection.

Moving notes to the trash from the list or the archive, one or several,
now shows Undo in a snackbar; it restores under the retention sweep's
lock, as the Trash screen does.

NoteRepository gains collection overloads whose defaults loop the
one-note call; the Room repository runs them in one transaction so the
list redraws once. Bulk tagging is not part of this.

Refs #596

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T15:09:40.672290Z 9d3be2b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jeiel85
jeiel85 merged commit cee4be6 into main Nov 18, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant