Repository navigation
feat: select several notes at once in the list, archive and trash (#596) - #597
Merged
Merged
Conversation
Long-press a note and choose Select, or pick Select notes from the overflow menu, then tap more notes. The bar acts on all of them: pin or unpin, archive, move to trash, select all, move to Locked. The archive gets Unarchive and Move to trash; in the trash a long press starts the selection, with Restore and Delete forever (asks first, with the count). Long-press still opens the one-note menu, so nothing changes until Select is used. Back or the close button ends the selection. Moving notes to the trash from the list or the archive, one or several, now shows Undo in a snackbar; it restores under the retention sweep's lock, as the Trash screen does. NoteRepository gains collection overloads whose defaults loop the one-note call; the Room repository runs them in one transaction so the list redraws once. Bulk tagging is not part of this. Refs #596 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the idea from Discussion #596 (@jardrog): act on several notes at once.
What changes
TrashPurge.lock).NoteRepository(default bodies loop the one-note call, so fakes need no change);LocalNoteRepositoryruns them in onewithTransactionso the list redraws once.Long-press keeps opening the menu, so nothing changes for anyone who doesn't use Select. Bulk tagging is not included (a tag is text in each note; it is listed under Limits and left open in the Discussion).
Checks
NotesListSelectionTest(7),ArchiveAndTrashSelectionTest(4),LocalNoteRepositoryTest+1.testDebugUnitTeston Windows: 1508 tests, 2 failures inEditorPreviewFindTest/EditorSurvivesRotationTest(known intermittent in full Windows runs, pass alone).lintReleasepasses.markleaf-phone-api36: list selection, trash + Undo, trash-screen selection and restore, archive selection and unarchive. No crash inlogcat -b crash.Refs #596