Repository navigation
XRAY-167694 - Keep scan results paths valid on Windows when the Git URL has a port - #942
Open
Jordanh1996 wants to merge 2 commits into
Open
Jordanh1996 wants to merge 2 commits into
Jordanh1996 wants to merge 2 commits into
Conversation
…RL has a port Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jordanh1996
marked this pull request as ready for review
November 8, 2026 15:30
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

https://jfrog-int.atlassian.net/browse/XRAY-167694
Background
Frogbot on Windows against a self-hosted Git server whose clone URL has a port (
https://git.example.com:8443/...) never gets its results into the platform. The CDX upload returns 500, it is only logged as a warning, and the run still reports success.Description
The Artifactory results path was built with
filepath.Join, which on Windows adds.\in front of a first element containing:. That sentrepo_path: ./git.example.com:8443/..., which Artifactory rejects. These are Artifactory paths, so they are now joined withpath. That also removes the backslashes fromuploaded_artifact_pathon the analytics event.Only a
.gitsuffix is now stripped from the clone URL path, so a dotted repo name without one (socket.io,payments.api) keeps its full name instead of being cut at the dot.Tests
TestGetGitContextArtifactPath: fails on Windows before the fix, passes after.Real Frogbot
scan-repositoryon Windows,:8443clone URL, git-repo watch: upload 500 → upload succeeds, violations fetched, results link printed.Captured the analytics event on Windows:
uploaded_artifact_pathwent fromfrogbot\\git.example.com\\...tofrogbot/git.example.com:8443/....The pull request is targeting the
devbranch.All static analysis checks passed.
All tests have passed. If this feature is not already covered by the tests, new tests have been added.
Updated the Contributing page / ReadMe page / CI Workflow files if needed.
🤖 Generated with Claude Code