Skip to content

XRAY-167694 - Keep scan results paths valid on Windows when the Git URL has a port - #942

Open
Jordanh1996 wants to merge 2 commits into
jfrog:devfrom
Jordanh1996:XRAY-167694-windows-port-repo-path
Open

Jordanh1996 wants to merge 2 commits into
jfrog:devfrom
Jordanh1996:XRAY-167694-windows-port-repo-path

Conversation

@Jordanh1996

@Jordanh1996 Jordanh1996 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

https://jfrog-int.atlassian.net/browse/XRAY-167694

Background

Frogbot on Windows against a self-hosted Git server whose clone URL has a port (https://git.example.com:8443/...) never gets its results into the platform. The CDX upload returns 500, it is only logged as a warning, and the run still reports success.

Description

The Artifactory results path was built with filepath.Join, which on Windows adds .\ in front of a first element containing :. That sent repo_path: ./git.example.com:8443/..., which Artifactory rejects. These are Artifactory paths, so they are now joined with path. That also removes the backslashes from uploaded_artifact_path on the analytics event.

Only a .git suffix is now stripped from the clone URL path, so a dotted repo name without one (socket.io, payments.api) keeps its full name instead of being cut at the dot.

Tests

  • TestGetGitContextArtifactPath: fails on Windows before the fix, passes after.

  • Real Frogbot scan-repository on Windows, :8443 clone URL, git-repo watch: upload 500 → upload succeeds, violations fetched, results link printed.

  • Captured the analytics event on Windows: uploaded_artifact_path went from frogbot\\git.example.com\\... to frogbot/git.example.com:8443/....

  • The pull request is targeting the dev branch.

  • All static analysis checks passed.

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.


🤖 Generated with Claude Code

…RL has a port

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization, Workspace
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: b81307b6-f8d0-4eac-8d27-5979687ab867

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Jordanh1996
Jordanh1996 marked this pull request as ready for review November 8, 2026 15:30
@Jordanh1996 Jordanh1996 added the safe to test Approve running integration tests on a pull request label Nov 8, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


This branch was successfully deployed

1 active deployment
frogbot — 6b42b2d5 Deployed Nov 8, 2026 by Jordanh1996 via scan-pull-request #4783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant