Repository navigation
Add Bzlmod and exported CMake targets with independent consumer tests - #1
Merged
Merged
Conversation
jhurliman
marked this pull request as ready for review
September 10, 2026 07:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c06d78f2a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jhurliman
added a commit
that referenced
this pull request
Sep 10, 2026
Stacked on #1 (`modernization/bazel-cmake`). Complete the previously unvalidated Conan path, restore checked-in Make commands, and prepare the 2.0.0 release and BCR submission files. Replace the Conan 1 recipe with a Conan 2 header-library recipe with a transitive Eigen dependency and a compiled/running consumer test. Restore test/benchmark/coverage targets, update the Google Benchmark API and compiler coverage paths, and remove obsolete Travis configuration. Version metadata is synchronized across C++, CMake, Conan and Bzlmod. Add a BCR metadata generator that reads the release archive's MODULE.bazel and computes its source integrity. A separate test consumes that checksum-verified archive through a generated registry with only bazel_dep, without local_path_override. RELEASING.md documents the actual tag-archive download and registry submission steps. Validation: Conan 2.32 create/test_package passes locally; Make regression, Google Benchmark smoke and LLVM coverage runs pass; the generated-registry Bazel 9.2 consumer passes. CI adds Conan, Make/coverage, and registry consumption alongside the parent Bazel/CMake checks. Review #1's broken-Make-target finding is addressed here. No tag, package upload, or external BCR PR is created before the reviewed source is merged and released; those are the remaining publication actions, not missing implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make kdtreepp consumable by a Bazel monorepo through Bzlmod and a public header-only
@kdtreepp//:kdtreepptarget with an explicit Eigen dependency. A separate example module verifies consumption with a renamed repository, so integration does not depend on the checkout's repository name or root configuration. BCR registration remains a release step; the README documents local and pinned-commit overrides.Replace automatic Conan invocation and global compiler settings in CMake with an exported
kdtreepp::kdtreeppinterface target. Tests/benchmarks are opt-in, and installed consumers usefind_package. Add direct standard-library includes and deterministic nearest-neighbor/empty/singleton/duplicate-point regression checks. No algorithm or performance change is claimed.Validation on macOS arm64: Bazel 9.2.0 with Eigen 3.4.1 passes both the library regression and the separate renamed-repository consumer. CMake with Eigen 5.0.1 passes ASan/UBSan regression and installed consumer checks; the original Catch2 2.13.10 suite passes 210 assertions in three cases with sanitizers. CI adds Ubuntu Bazel and CMake checks. The legacy Conan 1 recipe is not validated and CMake no longer invokes it automatically; this build-workflow change is documented. No release or BCR submission has been made.
Stacked release follow-up: #2 replaces the legacy Conan recipe with a tested Conan 2 consumer, restores Make/coverage/benchmark commands, and adds checksum-based BCR registry-consumer validation and 2.0.0 release preparation.