Repository navigation
Conversation
Owner
|
Thanks @mosch for the independent bucket-size proposal. I reviewed it during #105. TokenBucket already supports independent bucketSize/tokensPerInterval. RateLimiter also imposes an interval cap, so a larger bucket would not permit a larger per-interval burst. This patch additionally leaves initial content set to tokensPerInterval, which can overfill a smaller configured bucket. Keeping the feature proposal open for an explicit contract: initial fill at capacity, impossible requests bounded by both limits, and deterministic tests for smaller/larger capacities and getWaitTime. The current README now distinguishes the two limiter models. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @jhurliman , thanks for this clean library!
I wanted to define the bucket size independent from the tokensPerInterval, so I added the option.
Let me know what you think!