Repository navigation
fix(release): stop changeversion from reverting the references/openspec gitlink - #303
Merged
Merged
Conversation
…e references/openspec gitlink Second identical release regression (06dec8b, then 7322807): the stash step deliberately ignores the submodule path, so a checkout whose submodule working tree still sits on the pre-rotation tag rides `git add -A` and the version commit silently reverts the recorded pin. Sync the working tree to the recorded gitlink before staging (`submodule update --init --force --checkout`) and refuse to commit any staged submodule pointer change — a version commit never legitimately rotates the pin. Also restores the main gitlink to v1.14.1 (87c3595) that 7322807 reverted.
…non-skip A reference-only PR scope (only references/openspec and/or CI scripts changed) skips Setup pnpm/Install/Prepare — their conditions require full|scoped — while the four direct-pnpm steps (test:ci, typecheck, warm cache, installed-CLI smoke) only checked fast_mode != 'skip', so the reference-only class failed deterministically with 'pnpm' not recognized (PR #303, twice). Align the four conditions with their setup dependencies; reference-only PRs now get a green no-op Windows gate while the ubuntu Fast Gate's reference validation stays authoritative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second identical release regression, now rooted out. Both
06dec8b9(14.0.0 release) and7322807d(14.0.1 release) silently reverted thereferences/openspecsubmodule gitlink — the second one undid PR #300's v1.14.1 pin minutes after it merged.Mechanism (found in
scripts/changeversion-auto.ts): the stash step deliberately ignoresreferences/openspec(IGNORED_DIRTY_PATHS), but a checkout whose submodule working tree still sits on the pre-rotation tag then rides the latergit add -A, so the version commit ships a pin revert.Fix (completes that original intent):
git submodule update --init --force --checkout references/openspecsyncs the working tree to the recorded gitlink.87c3595) that7322807dreverted; the CI pin guard re-validates it on this PR.Evidence: functional simulation in a detached worktree — drift the submodule to v1.13.0 (
M references/openspecappears, the exact regression pre-image), run the new sequence,git add -Astages zero submodule changes.No
packages/code changes → no changeset required (CI Scope confirms).