Skip to content

docs: align core behavior documentation - #69

Open
Fawzankhan-404 wants to merge 1 commit into
joelborch:mainfrom
Fawzankhan-404:achievement/flow-67-doc-accuracy
Open

Fawzankhan-404 wants to merge 1 commit into
joelborch:mainfrom
Fawzankhan-404:achievement/flow-67-doc-accuracy

Conversation

@Fawzankhan-404

@Fawzankhan-404 Fawzankhan-404 commented Oct 20, 2026 •

Copy link
Copy Markdown

Summary

  • Correct the core README to distinguish the private default for newly created spaces from the legacy workspace fallback on stored entities.
  • Explain that first sign-in with OWNER_EMAIL claims the seeded owner and calls upsertUser.
  • Correct the Durable Object WebSocket comment: the Worker sends X-Flow-User-Id; the query parameter is a direct-caller fallback.
  • Update the visibility module comment to describe the current defaults.

Closes #67.

Validation

  • pnpm typecheck — passed across all five workspace packages.
  • pnpm -r test — 1,061 tests passed across core, API, web, and importer.
  • pnpm --filter @flow/web build — passed (Vite emitted existing environment-variable and chunk-size warnings).
  • git diff --check — passed.
  • Documentation and comments only; no runtime behavior changed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T16:54:04.920786Z c519deb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bring packages/core/README.md and two code comments in line with current behavior

1 participant