Repository navigation
web: match board search against visible tags as well as titles - #71
Open
nahuel007ng wants to merge 1 commit into
Open
nahuel007ng wants to merge 1 commit into
nahuel007ng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #65
cardFilterinapps/web/src/board/filters.tsnow keeps a card when the trimmed, lowercased search query is a substring of its title or of any visible tag. Before, it only checked the title. Machine-onlyext:tags never match, because the tags go throughvisibleTagsfromapps/web/src/lib/fmt.ts, the same helper the card chrome uses. The assignee and "mine only" filters combine with search as before, andfiltersActiveis unchanged.The new
apps/web/src/board/filters.test.tscovers a title match, a tag match, anext:tag that does not match, and search combined with an assignee filter.Gates run locally with Node 22 and pnpm 11.12.0:
pnpm typecheckpasses,pnpm -r testpasses (web 112, core 415, api 476, importer 63), andpnpm --filter @flow/web buildsucceeds.Checklist
pnpm typecheckandpnpm -r testpass locallywrangler.jsonc) are included — onlywrangler.example.jsoncplaceholders@flow/sharedschemas, DO storage shape, MCP tools) are called out belowContract changes
None. Client-side filter only; tasks in the board snapshot already carry
tags.