Skip to content

Solves #456: Added s_proportion_diff_mf() and a_proportion_diff_mf(). - #497

Merged
wwojciech merged 6 commits into
devfrom
456_add_s_proportion_diff_mf
Sep 24, 2026
Merged

wwojciech merged 6 commits into
devfrom
456_add_s_proportion_diff_mf

Conversation

@wwojciech

Copy link
Copy Markdown
Collaborator

Solves #456

Checks

  • (Have you updated the NEWS.md ?)
  • (Have you added proper tests for new functions/features ?)
  • (Have you added new functions to the pkgdown.yml ?)
  • (Have you run document() on new functions ?)

@wwojciech wwojciech added this to the 2026-09-30 Code Freeze milestone Sep 23, 2026
@wwojciech wwojciech self-assigned this Sep 23, 2026
@wwojciech wwojciech added the enhancement New feature or request label Sep 23, 2026
@wwojciech

wwojciech commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator Author

Hi @danielinteractive, would you be able to review this PR? Thanks!

P.S. The test coverage is currently limited, as I’d like to confirm the function implementations first.

@danielinteractive danielinteractive left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wwojciech nice, please see comments below

Comment thread R/cond_proportion_diff.R
Comment thread R/cond_proportion_diff.R
Comment thread R/cond_proportion_diff.R
Comment thread R/cond_proportion_diff.R Outdated
Comment thread R/cond_proportion_diff.R Outdated
Comment thread tests/testthat/test-proportion_diff_mf.R Outdated
@wwojciech
wwojciech merged commit e399f9c into dev Sep 24, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add s_proportion_diff_mf() sfun (+afun) with method selection based on Mantel-Fleiss criterion.

3 participants