Skip to content

add test for a_freq_j using cmh sato where tern bug occured - #515

Merged
munoztd0 merged 3 commits into
devfrom
test-prop-diff-fix
Oct 2, 2026
Merged

munoztd0 merged 3 commits into
devfrom
test-prop-diff-fix

Conversation

@iaugusty

@iaugusty iaugusty commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Fixes #nnn

Checks

  • (Have you updated the NEWS.md ?)
  • (Have you added proper tests for new functions/features ?)
  • (Have you added new functions to the pkgdown.yml ?)
  • (Have you run document() on new functions ?)

@wwojciech
wwojciech self-requested a review October 2, 2026 11:25
@wwojciech wwojciech added the test label Oct 2, 2026
Comment thread tests/testthat/test-a_freq_j.R Outdated
Comment thread tests/testthat/test-a_freq_j.R Outdated

@wwojciech wwojciech left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iaugusty , good idea to have this test in place; but, no need to check s_proportion_diff() here, just check a_freq_j() only.

@wwojciech wwojciech left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, great, thanks @iaugusty for adding this!

@munoztd0
munoztd0 merged commit fc598f0 into dev Oct 2, 2026
18 checks passed
@munoztd0
munoztd0 deleted the test-prop-diff-fix branch October 2, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants