Skip to content

Fix strtod rounding - #298

Merged
mrabine merged 2 commits into
mainfrom
fix-strtod-rounding
Oct 24, 2026
Merged

mrabine merged 2 commits into
mainfrom
fix-strtod-rounding

Conversation

@mrabine

@mrabine mrabine commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codacy-production

codacy-production Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 12 complexity · 18 duplication

Metric Results
Complexity 12
Duplication 18

View in Codacy

🟢 Coverage 100.00% diff coverage · 0.00% coverage variation

Metric Results
Coverage variation ✅ 0.00% coverage variation
Diff coverage ✅ 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4ae5b9e) 15812 15552 98.36%
Head commit (7442a37) 15828 (+16) 15567 (+15) 98.35% (0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#298) 27 27 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.41%. Comparing base (4ae5b9e) to head (7442a37).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files         135      135              
  Lines       14898    14913      +15     
==========================================
+ Hits        14663    14677      +14     
- Misses        235      236       +1     
Flag Coverage Δ
unittests 98.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

coveralls commented Oct 24, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 40130015249

Coverage decreased (-0.005%) to 98.351%

Details

  • Coverage decreased (-0.005%) from the base build.
  • Patch coverage: 27 of 27 lines across 1 file are fully covered (100%).
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
core/include/join/wheel.hpp 1 99.66%

Coverage Stats

Coverage Status
Relevant Lines: 15828
Covered Lines: 15567
Line Coverage: 98.35%
Coverage Strength: 159572.83 hits per line

💛 - Coveralls

@mrabine
mrabine merged commit 6eebf34 into main Oct 24, 2026
15 checks passed
@mrabine
mrabine deleted the fix-strtod-rounding branch October 24, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants