fix: use parsed integer num instead of rawNum in repeat helper loop

src/helpers/repeat.ts

@@ -1,6 +1,6 @@
 import { HandlebarsHelper, HelperConstructorBlock } from "./helper";
 
 export const repeatHelper: HelperConstructorBlock = (ctx) => {
     return new HandlebarsHelper("repeat", function (rawNum, options) {
         const num = Number.parseInt(rawNum);
 
@@ -9,7 +9,7 @@
         }
 
         let ret = "";
-        for (let i = 0; i < rawNum; i++) {
+        for (let i = 0; i < num; i++) {
             ret += options.fn({ ...this, "repeat_index": i });
         }
         return ret;

tests/helpers/helpers.spec.ts

@@ -334,6 +334,21 @@ describe("Handlebars Helpers", () => {
             expect(template({ count: -1 })).toEqual("");
         });
 
+        // Regression test for #124. parseInt and the loop's own coercion
+        // disagree on trailing garbage: parseInt("3abc") is 3, but Number("3abc")
+        // is NaN, so comparing against the raw string silently produced nothing.
+        test("should use the parsed count when the input has trailing characters", () => {
+            const template = Handlebars.compile("{{#repeat count}}item{{/repeat}}");
+            expect(template({ count: "3abc" })).toEqual("itemitemitem");
+        });
+
+        // Same disagreement in the other direction: Number("3.7") is 3.7, so the
+        // raw comparison ran one iteration too many.
+        test("should use the parsed count when the input is fractional", () => {
+            const template = Handlebars.compile("{{#repeat count}}item{{/repeat}}");
+            expect(template({ count: "3.7" })).toEqual("itemitemitem");
+        });
+
         test("should repeat exactly once for count of 1", () => {
             const template = Handlebars.compile("{{#repeat 1}}only{{/repeat}}");
             expect(template({})).toEqual("only");