Skip to content

fix: make the monthly framework update workflow reviewable #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alondmnt merged 2 commits into from
Sep 16, 2026
Merged

fix: make the monthly framework update workflow reviewable #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9cf86c
fix: run CI on automated framework update PRs
alondmnt Sep 16, 2026
63b2021
fix: stop the framework update opening a new PR every month
alondmnt Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/update-framework.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ jobs:
if: steps.changes.outputs.has_changes == 'true'
uses: peter-evans/create-pull-request@v6
with:
# Without an explicit token this falls back to GITHUB_TOKEN, and
# GitHub suppresses workflow triggers for events raised by that
# token to avoid recursion. The result is a PR with zero check runs,
# which nobody can review with any confidence. Set
# FRAMEWORK_UPDATE_TOKEN to a PAT (or app token) with `repo` scope to
# get CI on these PRs. If it is unset, this degrades to the previous
# behaviour rather than failing the run.
token: ${{ secrets.FRAMEWORK_UPDATE_TOKEN || github.token }}
commit-message: 'chore: routine joplin plugin framework update'
title: 'chore: routine joplin plugin framework update'
body: |
Expand All @@ -58,8 +66,11 @@ jobs:
```json
${{ steps.new-tsconfig-json.outputs.content }}
```
# No branch-suffix: a fixed branch name makes the action update the
# existing open PR in place each month. With a timestamp suffix every
# run got its own branch and opened a fresh PR, so #168, #170 and #172
# ended up as three byte-identical PRs for a diff that had not moved.
branch: chore/update-plugin-framework
branch-suffix: timestamp
committer: Albus <bot@nishantwrp.com>
author: Albus <bot@nishantwrp.com>
delete-branch: true
Loading