Repository navigation
fix: avoid double-decoding dialog selection in getUserTemplateSelection - #180
Merged
alondmnt merged 1 commit intoOct 3, 2026
Conversation
Contributor
Author
|
Hey @alondmnt @nishantwrp, I've opened this PR to resolve issue #178. The redundant decode() call in getUserTemplateSelection was causing double-decoding for note titles with HTML entities. All unit tests are passing cleanly. Could you please review when you have a moment? And let me know if any improvements or adjustments are needed. |
Collaborator
|
Thank you @sh1vam31! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178
When selecting a template from the template selection dialog,
getUserTemplateSelectionwas callingdecode()on the value returned fromformData. Since Chromium automatically decodes HTML entity values upon form submission, this resulted in double-decoding, corrupting titles or content containing literal HTML entities (e.g.Q&A TemplatebecameQ&A Template).Fix
src/utils/templates.ts
decode()call ingetUserTemplateSelection(), returningtemplateValue || nulldirectly fromformDatadecodeimport fromhtml-entitiestests/utils/templates.spec.ts
should not double-decode template value containing literal HTML entities (#178)) verifying that literal entities likeQ&A Templateare preserved without double-decodingTesting
Q&A Templatetagged astemplateQ&A Templateand clicked SelectQ&A Templateinstead of being corrupted toQ&A Templatenpm test)