Skip to content

fix(#184): keep dollar signs in special variable values #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VanshajPoonia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(#184): keep dollar signs in special variable values #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,8 @@ export class Parser {
const splitVal = firstMatch.split(":");
const wrappedString = `${splitVal[0]}: "${splitVal.slice(1).join(":").trim()}"`;

definitionsBlock = definitionsBlock.replace(firstMatch, wrappedString);
// A replacer function stops "$" sequences in the value being read as replacement patterns
definitionsBlock = definitionsBlock.replace(firstMatch, () => wrappedString);
}

return definitionsBlock;
Expand Down
18 changes: 18 additions & 0 deletions tests/parser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,24 @@ describe("Template parser", () => {
expect(parsedTemplate).toBeNull();
});

test("should keep dollar signs in special variable values as written", async () => {
const template = {
id: "note-id",
title: "Some Template",
body: dedent`
---
template_title: Budget $$ and $& report

---
`
};

const parsedTemplate = await parser.parseTemplate(template);

assert(parsedTemplate);
expect(parsedTemplate.title).toEqual("Budget $$ and $& report");
});

test("should skip empty values in tags special variable", async () => {
const template = {
id: "note-id",
Expand Down