Repository navigation
Reuse the known width of a text when building spans - #284
Merged
Merged
Conversation
Building the spans of a picture computed the display width and the length of every unclipped text again, character by character, although the image already holds both. Reusing them makes the output faster. In a benchmark that writes whole 160x45 frames, a list with several columns and frames of colored braille characters took 15-16% less time, and a frame in which each row is a single text took half the time.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered with Claude while working on reprise.
Building the spans of a picture computed the display width and the length of every unclipped text again, character by character, although the image already holds both. Reusing them makes the output faster. In a benchmark that writes whole 160x45 frames, a list with several columns and frames of colored braille characters took 15-16% less time, and a frame in which each row is a single text took half the time.