Repository navigation
peer mail: fyi updates stay parked instead of starting a turn - #1688
Merged
Merged
Conversation
An idle root started a turn for every new unread peer batch, including status and scope updates that needed nothing from it. The inbox read then told the model to reply with peer_message unconditionally. After a finished answer, informational mail reopened the task: the model read the inbox and restated its earlier answer, sometimes twice. peer_message send takes fyi=true for an update that needs no action or reply. It is marked [fyi], stays readable in the inbox, and never starts an idle turn on its own; a later message that does ask for something still wakes the root. The inbox footer now says to reply only to a message that asks something. Refs #1137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1137.
Root cause
An idle root started a turn for every new unread peer batch, including status and scope updates that needed nothing from it. Reading the inbox then told the model to "reply with peer_message" unconditionally. After a finished answer, informational mail reopened the task: the model read the inbox and restated its earlier answer, sometimes twice.
Fix
peer_message sendtakesfyi: truefor an update that needs no action or reply. The message is marked[fyi], stays readable in the inbox, and never starts an idle turn on its own. A later message that does ask for something still wakes the root.[fyi]updates need no reply.fyikeeps today's behavior.Not covered
This doesn't classify mail the sender didn't mark, so an unmarked informational message can still start a turn. The Harness
send_messagepath has its own wording and is unchanged here. The issue stays open for those.Tests