Repository navigation
shell: retry a transient shell-handle failure and name its cause - #1690
Merged
Merged
Conversation
Reserving a durable shell handle mapped every unexpected error to ShellIdentityUnavailable, and the message always blamed HOME's .codegraff permissions. A transient fd or lock failure looked like broken storage, and the real cause was lost; the next call worked without any repair. Errors that don't say the storage itself is unusable are retried three times. The underlying error is kept and shown, and only a storage fault (access, read-only, full disk, missing or bad path) gets the permissions advice; anything else says it is usually transient. Fixes #1619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1619.
Root cause
shell_identity.forJobmapped every unexpected reservation error toShellIdentityUnavailable, which dropped the underlying error.exec_bash.spawnFailTextthen gave HOME-permissions repair advice for any of them. A transient fd or lock failure looked like broken storage, and the next call worked without any repair.Fix
shell_identity.last_cause) and shown:ShellIdentityUnavailable: <cause>.Tests