Repository navigation
events: pair every model_call_started with a model_call_finished - #1691
Merged
Merged
Conversation
A request rebuilt before its response (a WebSocket reanchor, a stream reconnect, a steer, a recovered overflow) emitted another model_call_started without closing the attempt before it, and a request that ended with an error closed nothing. Strict JSON clients could not pair attempts. model_call.Call tracks the open attempt. A rebuilt request closes it with ok=false and retried=true before the next one starts; an error return closes it with ok=false and retried=false. Successful attempts are unchanged. The schema and SDK event types document the optional retried field. Fixes #1665
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1665.
Root cause
agent_request.requestemittedmodel_call_startedat the top of its rebuild loop. A request rebuilt before its response (a WebSocket reanchor, a stream reconnect, a steer, a recovered overflow) emitted anothermodel_call_startedwithout closing the attempt before it. A request that ended with an error closed nothing.Fix
model_call.Calltracks the open attempt.ok: false, retried: truebefore the next one starts.errdefer) withok: false, retried: false.--schemaevents and the SDK event types document the optionalretriedfield.Not changed
Recovery is still reported as transport detail rather than a typed retry event, and there is no attempt-budget control. Both are separate from pairing.
Tests
retried: false.