Repository navigation
fix(websocket): isolate routes per server without callback cycles - #229
Merged
Merged
Conversation
Contributor
Performance Regression Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227.
Scopes native WebSocket route registries to each TurboServer/listener, carries registry identity through accepted connections and queued work, preserves app-local live replacement, and retains owned handler/guard snapshots for in-flight jobs.
Callback ownership is Python-GC-visible, so bound methods and closures that capture their app/server do not form hidden native cycles. Native registry entries borrow the state-owned callbacks; queued/in-flight work owns explicit snapshots. Interpreter checks happen before mutation and registration remains transactional.
Validation on current main:
No production deployment or release is included.