Repository navigation
26.3 port, security fixes, CI + releases (0.1.3) - #5
Merged
Merged
Conversation
Security review fixes: - H1: a corrupt mail store is backed up (.corrupt-<millis>) before starting over instead of being overwritten at boot; saves are atomic. MailFilesTest. - M1: /postbox testsend and take require standing at your own mailbox. - M2: outbox requests with a malformed toUuid are dropped on ingest; delivery no longer throws on a bad recipient inside the server tick. - L1: config parse failure no longer overwrites the file; knobs clamped on load. PostboxConfigTest. - L2: leftover express couriers are removed when they load. - L3: random mailbox ids (no gameTime+count collisions). Lines: main targets 26.3 (pins follow sanctuary main); 26.2 moved to its own branch. sgui and the dev run dir are per-line gradle.properties values (the 26.1 jar used to bundle sgui 2.1.0+26.2). fabric.mod.json takes "minecraft" from minecraft_version. CI: build, unit tests, two-boot real server test, per-line badges, tag-triggered releases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuNimi9Rxqawpjz4vh6bt9
This was referenced Oct 2, 2026
k33bz
marked this pull request as ready for review
October 2, 2026 21:09
k33bz
added a commit
that referenced
this pull request
Oct 2, 2026
Same change as main (#5): security fixes, CI server test, badges, releases, CHANGELOG. Pins follow sanctuary 26.2: loader 0.19.5, fabric-api 0.161.0+26.2, sgui 2.1.0+26.2; dev run dir run262. Claude-Session: https://claude.ai/code/session_01DuNimi9Rxqawpjz4vh6bt9 Co-authored-by: Claude <noreply@anthropic.com>
k33bz
added a commit
that referenced
this pull request
Oct 2, 2026
Same change as main (#5): security fixes, CI server test, badges, releases, CHANGELOG. Pins follow sanctuary 26.1: loader 0.19.5, fabric-api 0.155.3+26.1.2, sgui 2.0.0+26.1; dev run dir run. Claude-Session: https://claude.ai/code/session_01DuNimi9Rxqawpjz4vh6bt9 Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings Postbox up to the standard of sanctuary, sswaystones and pathways. This PR is
main, now Minecraft 26.3; the same change goes to the new26.2branch and to26.1in follow-up PRs.Security review fixes
postbox_mail.jsonthat failed to parse was replaced by an empty store saved straight over it at boot. That lost every mailbox, queue and in-transit letter, and letters are real books. Now the damaged file is copied to.corrupt-<millis>first (boot refuses to continue if that copy fails), and saves are atomic: temp file, then move. Null entries are dropped.MailFiles+MailFilesTest./postbox testsendandtakefrom anywhere. Permission-0 test backends let anyone send from, or empty, their mailbox anywhere in the world. They now follow the send dialog's 8-block rule (SendDialog.inReach).toUuidcrashed the server tick at delivery, and kept crashing it after every restart. Requests are now validated on ingest, andDeliveryno longer throws on a bad recipient.postbox.jsonis no longer overwritten with defaults. Every knob is clamped on load:postageCharsPerEmerald: 0made mail free, and a negativemaxQueuedblocked all mail.PostboxConfigTest.Checked and fine: owner-only dismantle, the 8-block send session, pay-before-consume, the earlier SNBT escaping, and book contents (no command injection).
Lines and build
main: loader 0.19.5, fabric-api 0.161.0+26.3, sgui 2.2.1+26.3.build.gradle(sgui 2.1.0+26.2,run262) and shared by every branch. So the 26.1 jar bundled the 26.2 sgui, which on a 26.1.2 server also replaces sanctuary's bundled copy. Both are now per-linegradle.propertiesvalues.fabric.mod.jsontakes~minecraft_version, so each jar only loads on its own line.CI and releases
build.yml: build and unit tests (Postage, MailFiles and PostboxConfig; 19 run locally), the existing mappings-diagnosis step, andscripts/server_test.py. The server test does two real-server boots:/mail, and the outbox: a valid request is delivered as a written book and a malformed one is dropped. It also checks Lost Mail from a slain trader and stray-courier removal.It also publishes per-line badges.
release.yml: on av<mod>+<mc>tag it checks the tag against the commit, builds, runs the server test, and publishes a GitHub release with notes from the changelog.CHANGELOG rewritten with real version entries; README covers branches, badges, CI and the store's safety.
This PR's CI is the first 26.3 compile and the first real-server run.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DuNimi9Rxqawpjz4vh6bt9
Generated by Claude Code