[ON-HOLD] feat: initial commit for kadena ledger lib - #2458
Draft
barthuijgen wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
nillo
suggested changes
Aug 8, 2024
| <div> | ||
| <button | ||
| className="bg-blue-500 hover:bg-blue-700 text-white font-bold py-2 px-4 rounded" | ||
| onClick={() => openApp().then(() => setOpenAppResult('success'))} |
Contributor
There was a problem hiding this comment.
onClick={async () => {
await openApp();
setOpenAppResult('success');
}}
| <div> | ||
| <button | ||
| className="bg-blue-500 hover:bg-blue-700 text-white font-bold py-2 px-4 rounded" | ||
| onClick={() => |
Contributor
There was a problem hiding this comment.
onClick={async () => {
const result = await getPublicKey(0);
setGetPublicKeyResult(result);
}}
| <div> | ||
| <button | ||
| className="bg-blue-500 hover:bg-blue-700 text-white font-bold py-2 px-4 rounded" | ||
| onClick={() => getVersion().then((x) => setGetVersionResult(x))} |
Contributor
There was a problem hiding this comment.
onClick={async () => {
const result = await getVersion();
setGetVersionResult(result);
}}
| <div> | ||
| <button | ||
| className="bg-blue-500 hover:bg-blue-700 text-white font-bold py-2 px-4 rounded" | ||
| onClick={() => |
Contributor
There was a problem hiding this comment.
onClick={async () => {
const result = await signTransaction(0, 'transfer', {
recipient: '2017fee3fb15cfe840e5ed34bf101cc7d5579ffdd20dea09e32fd77c1757f946',
recipientChainId: '0',
networkId: 'testnet04',
amount: 0.1,
namespace_: '',
module_: '',
gasPrice: '1.0e-6',
gasLimit: '2300',
creationTime: '1723017869',
chainId: '0',
nonce: '',
ttl: '600',
type: 'transfer',
});
setSignTransactionResult(result);
}}
| 0x00, | ||
| Buffer.from('Kadena', 'ascii'), | ||
| ); | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)); |
Contributor
There was a problem hiding this comment.
I still don't know why this is here and it probably should not bere here, since is does not make sense.
| @@ -0,0 +1,9 @@ | |||
| import { StrictMode } from 'react'; | |||
Contributor
There was a problem hiding this comment.
import { StrictMode } from 'react';
import { createRoot } from 'react-dom/client';
import App from './app.tsx';
const root = createRoot(document.getElementById('root')!);
root.render(
<StrictMode>
<App />
</StrictMode>,
);
| @@ -0,0 +1,33 @@ | |||
| import { KadenaLedger } from './ledger'; | |||
Contributor
There was a problem hiding this comment.
add return types:
import { KadenaLedger } from './ledger';
import { TransactionParams } from './transaction';
let ledger: KadenaLedger | null = null;
async function getLedger(): Promise<KadenaLedger> {
if (!ledger) ledger = await KadenaLedger.findDevice();
return ledger;
}
export async function openApp(): Promise<void> {
const ledger = await getLedger();
return await ledger.openApp();
}
export async function getPublicKey(index: number): Promise<string> {
const ledger = await getLedger();
return await ledger.getPublicKey(index);
}
export async function signTransaction(
index: number,
type: 'transfer' | 'cross-chain-transfer',
params: TransactionParams,
): Promise<string> {
const ledger = await getLedger();
return await ledger.signTransaction(index, type, params);
}
export async function getVersion(): Promise<string> {
const ledger = await getLedger();
return await ledger.getVersion();
}
| [StatusCodes.OK, 0x6e01], // 0x6e01 = already open | ||
| ); | ||
| // Opening the app makes the device reconnect, wait a moment for this | ||
| await new Promise((resolve) => setTimeout(resolve, 500)); |
Contributor
There was a problem hiding this comment.
that's should be done more smarter, the reconnecting' isn't. there a event available we can listen to, this doesn't seem very error prone
| appName: string; | ||
| }> { | ||
| const response = await this.transport.send( | ||
| 0x00, |
Contributor
There was a problem hiding this comment.
can these codes be identified? in some sort of map.
barthuijgen
changed the title
barthuijgen
force-pushed
the
feat/kadena-ledger-lib
branch
from
October 3, 2024 11:32
e48c9d3 to
4915137
Compare
Contributor
|
This PR is stale because it is open for 60 days with no activity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify this title
Related Issue/Asana ticket: _
Short description: Add a library called
@kadena/ledgerthat allows integration with the kadena ledger app via browser HID.Currently ON-HOLD because the kadena app is being re-written.
Test scenarios
Reminders (if applicable)
pnpm installandpnpm testin the root of the monorepo(optionally with
--filter=...package...to exclude non-affectedprojects)
pnpm changesetin the root of the monorepodocs.kadena.io)