Skip to content

Require manual dependency review and isolate Pages permissions - #60

Merged
kahwee merged 2 commits into
mainfrom
fix/manual-dependency-review-20261111
Nov 11, 2026
Merged

kahwee merged 2 commits into
mainfrom
fix/manual-dependency-review-20261111

Conversation

@kahwee

@kahwee kahwee commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Remove automatic Dependabot approval and merging: patch/minor metadata and passing checks do not replace upstream review before changes reach the public Storybook.
  • Give Storybook PR builds an explicit read-only token; restrict Pages and OIDC write permissions to the isolated deployment job.
  • Document the manual review requirement and run a credential-free workflow security regression guard in CI.

Verification

  • Passed locally: six workflow/release guard tests, YAML parsing of remaining workflows, and git diff --check.
  • PR CI passed at d56ec14: Check and Build (formatting, typechecking, 11 unit tests, package build) and Storybook Build.
  • Independent review found no blocking findings. Latest main was unchanged before a SHA-guarded squash merge, authorized by the user.
  • Verified main at 21fd1b3 with matching tested tree.
  • Postmerge Check and Build, Storybook Build, and normal Pages deployment all passed.

No package release or repository settings changed. Existing auto-merge state or prior approvals on other open PRs are not revoked by removing this workflow.

@kahwee
kahwee marked this pull request as ready for review November 11, 2026 11:38
@kahwee
kahwee merged commit 21fd1b3 into main Nov 11, 2026
2 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T11:39:46.434610Z d56ec14 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-11T11:40:30.036839Z d56ec14 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant